Fixes the issue of not being able to receive Jaeger HotROD 1.61.0 via OpenTelemetry SDK #4972
+25
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
linghengqian
force-pushed
the
re-example
branch
2 times, most recently
from
8c21e9e
to
2823b94
Compare
… OpenTelemetry SDK Signed-off-by: linghengqian <linghengqian@outlook.com>
linghengqian
force-pushed
the
re-example
branch
from
2823b94
to
71b71e5
Compare
linghengqian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
jaegertracing/jaeger-agentto receivejaegertracing/example-hotroddata, but directly usesotel/opentelemetry-collector-contrib. According to https://www.jaegertracing.io/docs/1.60/deployment/#agent ,jaegertracing/jaeger-agentis considered a deprecated component. It does not make any sense.insecure_skip_verifyneeds to be configured in the first place.insecure_skip_verifyandinsecureshould not be configured at the same time. See https://github.com/open-telemetry/opentelemetry-collector/blob/v0.109.0/config/configtls/README.md and https://github.com/open-telemetry/opentelemetry-collector/blob/v0.109.0/exporter/otlpexporter/README.md.otel/opentelemetry-collector-contribinstead ofotel/opentelemetry-collectoris very simple. https://opentelemetry.io/docs/collector/installation/ does not introduceotel/opentelemetry-collectorat all, and that Docker Image does not look like it is for end users.otlp/2is obviously a custom name, I don't understand why it wasotlp/2in the first place. The source seems to be from https://www.youtube.com/watch?v=WhRrwSHDBFs .Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.